Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention documentation comments in GDScript basics #10097

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 16, 2024

@Calinou Calinou added enhancement topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 labels Oct 16, 2024
@Calinou Calinou force-pushed the gdscript-basics-documentation-comments branch 2 times, most recently from 8b882b8 to bef0e50 Compare October 16, 2024 15:53
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to merge as-is, but I have two possible suggestions to bring this more in line with the rest of the page.

  • Add a code block with the most common examples.
  • Shorten the paragraph and just link to the main page, as is done for Exports and History.

tutorials/scripting/gdscript/gdscript_basics.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdscript/gdscript_basics.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the gdscript-basics-documentation-comments branch from bef0e50 to 594a1d6 Compare October 17, 2024 13:12
@mhilbrunner mhilbrunner merged commit 8d28f0f into godotengine:master Oct 18, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Merged.

@Calinou Calinou deleted the gdscript-basics-documentation-comments branch November 22, 2024 23:16
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants